[libvirt] [PATCH 06/12] qemu: block: Add JSON props generator for iSCSI protocol
Ján Tomko
jtomko at redhat.com
Sun Nov 5 15:03:25 UTC 2017
On Fri, Nov 03, 2017 at 03:29:23PM +0100, Peter Krempa wrote:
>From: John Ferlan <jferlan at redhat.com>
>
>---
>+static virJSONValuePtr
>+qemuBlockStorageSourceGetISCSIProps(virStorageSourcePtr src)
>+{
[...]
>+ if (VIR_STRDUP(target, src->path) < 0)
>+ goto cleanup;
>+
>+ /* Separate the target and lun */
>+ if ((lunStr = strchr(target, '/'))) {
>+ *(lunStr++) = '\0';
>+ if (virStrToLong_ui(lunStr, NULL, 10, &lun) < 0) {
>+ virReportError(VIR_ERR_INTERNAL_ERROR,
>+ _("cannot parse target for lunStr '%s'"),
>+ target);
>+ goto cleanup;
>+ }
>+ }
>+
>+ /* combine host and port into portal */
>+ if (virAsprintf(&portal, "%s:%u", src->hosts[0].name, src->hosts[0].port) < 0)
>+ goto cleanup;
Can src->hosts[0].name possibly be a literal IPv6 address?
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171105/7787a256/attachment-0001.sig>
More information about the libvir-list
mailing list