[libvirt] [PATCH 02/21] util: Introduce virPrettySize

[Martin Kletzander]

On Mon, Nov 13, 2017 at 01:36:58PM -0500, John Ferlan wrote:
>
>
>On 11/13/2017 03:50 AM, Martin Kletzander wrote:
>> We can't output better memory sizes if we want to be compatible with libvirt
>> older than the one which introduced /memory/unit, but for new things we can just
>> output nicer capacity to the user if available.  And this function enables that.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/libvirt_private.syms |  1 +
>>  src/util/virutil.c       | 50 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  src/util/virutil.h       |  3 +++
>>  3 files changed, 54 insertions(+)
>>
>
>Since we have virFormatIntDecimal, why not change the name to be
>virFormatPrettySize. I'd also support moving it closer to the virFormat*
>function (both .c and .h), but it's not a "requirement"...
>

Sure, I can do that.

>Reviewed-by: John Ferlan <jferlan at redhat.com>
>
>John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171114/f0688857/attachment-0001.sig>