[libvirt] [PATCH] Print hex values with '0x' prefix and octal with '0' in debug messages

Ján Tomko jtomko at redhat.com
Mon Sep 25 11:27:24 UTC 2017


On Mon, Sep 25, 2017 at 11:45:51AM +0100, Daniel P. Berrange wrote:
>Seeing a log message saying 'flags=93' is ambiguous & confusing unless
>you happen to know that libvirt always prints flags as hex.  Change our
>debug messages so that they always add a '0x' prefix when printing flags,
>and '0' prefix when printing mode. A few other misc places gain a '0x'
>prefix in error messages too.
>
>Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
>---

ACK

On top of these, the flagx= typo in virNodeAllocPages might deserve to
be included in this patch. Not sure about virAdmServerSetThreadPoolParameters
which is the only one using hex format for nparams:

src/libvirt-admin.c=826=virAdmServerSetThreadPoolParameters(virAdmServerPtr srv,
--
src/libvirt-admin.c:831:    VIR_DEBUG("srv=%p, params=%p, nparams=%x, flags=0x%x",
src/libvirt-admin.c-832-              srv, params, nparams, flags);
--
src/libvirt-domain.c=11901=virDomainSetGuestVcpus(virDomainPtr domain,
--
src/libvirt-domain.c:11906:    VIR_DOMAIN_DEBUG(domain, "cpumap='%s' state=%x flags=0x%x",
src/libvirt-domain.c-11907-                     NULLSTR(cpumap), state, flags);
--
src/libvirt-host.c=1448=virNodeAllocPages(virConnectPtr conn,
--
src/libvirt-host.c-1456-    VIR_DEBUG("conn=%p npages=%u pageSizes=%p pageCounts=%p "
src/libvirt-host.c:1457:              "startCell=%d cellCount=%u flagx=%x",
src/libvirt-host.c-1458-              conn, npages, pageSizes, pageCounts, startCell,
src/libvirt-host.c-1459-              cellCount, flags);

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170925/8a820868/attachment-0001.sig>


More information about the libvir-list mailing list