[libvirt] [PATCH] virsh: Add/allow secret-uuid for pool-{define|create}-as

[John Ferlan]

On 09/27/2017 05:24 AM, Erik Skultety wrote:
> On Tue, Sep 05, 2017 at 02:42:58PM -0400, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1476775
>>
>> For the virsh pool-{define|create}-as command, let's allow using
>> --secret-uuid on the command line as an alternative to --secret-usage,
>> but ensure that they are mutually exclusive.
>>
>> Not sure why I neglected to add it for commit id '8932580'
> 
> ^This is IMHO more suitable under the --- :)

Kind of an after thought when I wrote it, but I also think working it
into the commit message is good for the ease of chasing history...

> 
> 
> [...]
> 
>> diff --git a/tools/virsh.pod b/tools/virsh.pod
>> index c13f96f..bf5a124 100644
>> --- a/tools/virsh.pod
>> +++ b/tools/virsh.pod
>> @@ -3673,7 +3673,8 @@ just I<--build> is provided, then B<pool-build> is called with no flags.
>>  =item B<pool-create-as> I<name> I<type>
>>  [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>]
>>  [I<--source-name name>] [I<--target path>] [I<--source-format format>]
>> -[I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>]
>> +[I<--auth-type authtype> I<--auth-username username>
> 
> pool-define-as should have the argument list updated the same way as
> pool-create-as and by that I of course mean just the enumeration, since
> pool-define-as states that the arguments mean the same thing as for
> pool-create-as.
> 
> Reviewed-by: Erik Skultety <eskultet at redhat.com> (with the tiny adjustment)
> 

oh right - thanks...

Fixed things up and pushed.

John