[libvirt] [PATCH 4/7] remote: use a separate connection for nodedev APIs
John Ferlan
jferlan at redhat.com
Wed Apr 4 17:50:15 UTC 2018
On 03/28/2018 11:18 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
> src/remote/remote_daemon.h | 1 +
> src/remote/remote_daemon_dispatch.c | 19 +++++++++++--------
> src/rpc/gendispatch.pl | 6 ++++++
> 3 files changed, 18 insertions(+), 8 deletions(-)
>
[...]
> diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl
> index 5bab13bb7b..0e7567fbde 100755
> --- a/src/rpc/gendispatch.pl
> +++ b/src/rpc/gendispatch.pl
> @@ -131,6 +131,9 @@ sub get_conn_arg {
> if ($type =~ /remote_nonnull_network/) {
> return "priv->networkConn";
> }
> + if ($type =~ /remote_nonnull_node_device/) {
> + return "priv->nodedevConn";
> + }
> }
>
> # This is for the few virConnect APIs that
> @@ -142,6 +145,9 @@ sub get_conn_arg {
> if ($proc =~ /Connect.*Network/) {
> return "priv->networkConn";
> }
> + if ($proc =~ /Node.*Device/) {
Originally I thought this should be NodeDevice; however, I see you're
picking up the NumOfDevices and ListDevices by this syntax.
Hopefully some day there isn't a *NodeGet*Device* entry for those Node,
but not NodeDevice API's... That'd be a bugger to find.
Reviewed-by: John Ferlan <jferlan at redhat.com>
John
> + return "priv->nodedevConn";
> + }
>
> return "priv->conn";
> }
>
More information about the libvir-list
mailing list