[libvirt] [PATCH 3/4] util: virlog: Introduce wildcard to log filters

[Ján Tomko]

On Tue, Apr 03, 2018 at 10:45:48AM +0200, Erik Skultety wrote:
>Since the introduction of log tuning capabilities to virt-admin by
>@06b91785, this has been a much needed missing improvement on the way to
>deprecate the global 'log_level'.
>
>Signed-off-by: Erik Skultety <eskultet at redhat.com>
>---
> src/remote/libvirtd.conf |  4 +++-
> src/util/virlog.c        | 44 +++++++++++++++++++++++++++++++++++++++++++-
> src/util/virlog.h        |  1 +
> 3 files changed, 47 insertions(+), 2 deletions(-)
>

ACK

>diff --git a/src/remote/libvirtd.conf b/src/remote/libvirtd.conf
>index 9c0080dc0..7d823cf1a 100644
>--- a/src/remote/libvirtd.conf
>+++ b/src/remote/libvirtd.conf
>@@ -368,7 +368,9 @@
> # Multiple filters can be defined in a single @filters, they just need to be
> # separated by spaces. Note that libvirt performs "first" match, i.e. if
> # there are concurrent filters, the first one that matches will be applied,
>-# given the order in log_filters.
>+# given the order in log_filters with the exception of a wildcard filter, since
>+# that's only taken into account if no other filter has matched, so
>+# "4:* 1:util.pci" and "1:util.pci 4:*" are equivalent definitions.
> #

Also, "4:* 1:util.pci 1:*" is equivalent.

> # e.g. to only get warning or errors from the remote layer and only errors
> # from the event layer:

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180406/c2d21957/attachment-0001.sig>