[libvirt] [jenkins-ci PATCH 12/10] guests: Enable bash completion by default

[Pavel Hrdina]

On Mon, Apr 09, 2018 at 10:11:23AM +0200, Andrea Bolognani wrote:
> On Mon, 2018-04-09 at 09:22 +0200, Pavel Hrdina wrote:
> [...]
> > > diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml
> > > index a0483d8..49d4d2e 100644
> > > --- a/guests/vars/projects/base.yml
> > > +++ b/guests/vars/projects/base.yml
> > > @@ -4,6 +4,7 @@ packages:
> > >    - automake
> > >    - autopoint
> > >    - bash
> > > +  - bash-completion
> > >    - ccache
> > >    - chrony
> > >    - cppi
> > > diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml
> > > index 9f027f8..598dfc4 100644
> > > --- a/guests/vars/projects/libvirt.yml
> > > +++ b/guests/vars/projects/libvirt.yml
> > > @@ -3,7 +3,6 @@ packages:
> > >    - apparmor
> > >    - augeas
> > >    - avahi
> > > -  - bash-completion
> > 
> > I'm not sure about removing it from libvirt dependencies.  I think we
> > should keep it in both places since it's an extension that improves
> > testing environment and also it's a dependency of libvirt.
> 
> The whole point of 'base' is not having to list packages more than
> once: if someone wants to get the full list of dependencies for
> building a project, they're going to have to take both those specific
> to the project itself and those in base anyway, which is exactly what
> I do every time I sync the Travis CI configuration with the CentOS CI
> configuration. I don't see any reason to treat bash-completion
> differently.

OK, good enough :)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180409/25abf468/attachment-0001.sig>