[libvirt] [libvirt PATCH v2 01/44] qemuxml2argvtest: Fix q35-virt-manager capabilities

Andrea Bolognani abologna at redhat.com
Mon Apr 9 14:49:18 UTC 2018


On Thu, 2018-04-05 at 14:22 +0200, Ján Tomko wrote:
> Use QEMU_CAPS_MACHINE_OPT and QEMU_CAPS_MACHINE_VMPORT_OPT
> since it specifies <vmport state=off/>.
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  tests/qemuxml2argvdata/q35-virt-manager-basic.args | 2 +-
>  tests/qemuxml2argvtest.c                           | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)

Kinda weird that we don't just error out if vmport is configured
and we clearly have no way of enforcing it.

Regardless,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list