[libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

[Ján Tomko]

On Thu, Apr 12, 2018 at 10:41:03AM +0200, Andrea Bolognani wrote:
>On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote:
>> Implied by QEMU >= 1.2.0.
>>
>> Signed-off-by: Ján Tomko <jtomko at redhat.com>
>> ---
>>  src/qemu/qemu_capabilities.c                         |  1 -
>>  src/qemu/qemu_capabilities.h                         |  2 +-
>>  src/qemu/qemu_command.c                              | 20 ++++++++------------
>>  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml   |  1 -
>>  tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml    |  1 -
>>  tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml   |  1 -
>>  tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml    |  1 -
>>  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml    |  1 -
>>  tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml      |  1 -
>>  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml      |  1 -
>>  tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml      |  1 -
>>  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml     |  1 -
>>  tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml      |  1 -
>>  tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml      |  1 -
>>  tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml     |  1 -
>>  .../disk-drive-network-tlsx509-vxhs.args             |  6 +++---
>>  tests/qemuxml2argvdata/disk-drive-network-vxhs.args  |  2 +-
>>  tests/qemuxml2argvdata/disk-scsi-disk-wwn.args       |  2 +-
>>  tests/qemuxml2argvtest.c                             |  8 +++-----
>>  32 files changed, 17 insertions(+), 49 deletions(-)
>
>I just realized that all of these should have a qemu: prefix in
>the first line of the commit message. Before pushing, can you
>please make sure they do?
>

I rarely use prefixes, they take up valuable space in the commit
summary.

'QEMU' is already contained in QEMU_CAPS if you're reading the single
commit summary.

If you want to see changes just from qemu, you can filter by the
src/qemu path

So what is the value they add?

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180412/32ca049b/attachment-0001.sig>