[libvirt] [dbus PATCH v2 13/22] Implement HasManagedSaveImage method for Domain Interface

Pavel Hrdina phrdina at redhat.com
Fri Apr 13 10:06:44 UTC 2018


On Thu, Apr 12, 2018 at 04:32:52PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
> ---
>  data/org.libvirt.Domain.xml |  6 ++++++
>  src/domain.c                | 29 +++++++++++++++++++++++++++++
>  test/test_domain.py         |  2 +-
>  3 files changed, 36 insertions(+), 1 deletion(-)
> 
> diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> index 382b062..57e5ea4 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -90,6 +90,12 @@
>        <arg name="flags" type="u" direction="in"/>
>        <arg name="xml" type="s" direction="out"/>
>      </method>
> +    <method name="HasManagedSaveImage">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainHasManagedSaveImage"/>
> +      <arg name="flags" type="u" direction="in"/>
> +      <arg name="managedSaveImage" type="u" direction="out"/>

I would change the type to 'b', the return value is 0 or 1.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180413/9fb479cd/attachment-0001.sig>


More information about the libvir-list mailing list