[libvirt] [PATCH 2/8] qemu: introduce vfio-ccw capability

[Shalini Chellathurai Saroja]

On 04/12/2018 10:44 AM, Cornelia Huck wrote:
> On Wed, 11 Apr 2018 17:49:53 +0200
> Shalini Chellathurai Saroja <shalini at linux.vnet.ibm.com> wrote:
>
>> Let us introduce the capability vfio-ccw for supporting the basic
>> channel I/O passthrough, which have been introduced in QEMU 2.10. The
>> current focus is to support dasd-eckd (cu_type/dev_type = 0x3990/0x3390)
>> as the target device.
>>
>> Let us also introduce the capability QEMU_CAPS_CCW_CSSID_UNRESTRICTED
>> for virtual-css-bridge. This capability is based on the
>> cssid-unrestricted property which exists if QEMU no longer enforces
>> cssid restrictions based on ccw device types.
>>
>> Vfio-ccw capability is dependent on the hidden virtual-css-bridge, so
>> that we are able to probe for the cssid-unrestriced property.
> You depend on the unrestricted cssids and do not support the old,
> deprecated squash-mcss approach? Makes sense.
>
> I'm not familiar with libvirt conventions, but does it make sense to
> add a comment _why_ vfio-ccw depends on unrestricted cssids (i.e., to
> make sure the devices are visible to non-mcss-e enabled guests?)

ok, I will add the comment, thanks.

>> Signed-off-by: Shalini Chellathurai Saroja <shalini at linux.vnet.ibm.com>
>> Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> ---
>>   src/qemu/qemu_capabilities.c                       | 14 ++++++++++
>>   src/qemu/qemu_capabilities.h                       |  4 +++
>>   .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 28 ++++++++++++-------
>>   tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   |  2 +-
>>   .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 28 ++++++++++++-------
>>   tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   |  2 +-
>>   .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 31 ++++++++++++++++------
>>   tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   |  3 +++
>>   .../qemucapabilitiesdata/caps_2.7.0.s390x.replies  | 24 ++++++++++++-----
>>   tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml    |  2 +-
>>   .../qemucapabilitiesdata/caps_2.8.0.s390x.replies  | 28 ++++++++++++-------
>>   tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |  2 +-
>>   .../qemucapabilitiesdata/caps_2.9.0.s390x.replies  | 28 ++++++++++++-------
>>   tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml    |  2 +-
>>   14 files changed, 142 insertions(+), 56 deletions(-)
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>