[libvirt] [PATCH v2 67/73] qemu: Store API flags for async jobs in qemuDomainJobObj

[Ján Tomko]

On Wed, Apr 11, 2018 at 04:41:57PM +0200, Jiri Denemark wrote:
>When an async job is running, we sometimes need to know how it was
>started to distinguish between several types of the job, e.g., post-copy
>vs. normal migration. So far we added a specific bool item to
>qemuDomainJobObj for such cases, which doesn't scale very well and
>storing such bools in status XML would be painful so we didn't do it.
>
>A better approach is to store the flags passed to the API which started
>the async job, which can be easily stored in status XML.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/qemu/qemu_domain.c    | 10 ++++++++--
> src/qemu/qemu_domain.h    |  4 +++-
> src/qemu/qemu_driver.c    | 31 +++++++++++++++++++------------
> src/qemu/qemu_migration.c | 20 +++++++++++++-------
> src/qemu/qemu_process.c   |  5 +++--
> src/qemu/qemu_process.h   |  3 ++-
> 6 files changed, 48 insertions(+), 25 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180416/cf2919d9/attachment-0001.sig>