[libvirt] [PATCH v3 5/7] tests: qemuxml2argv: Test formatting of 'write-cache' parameter

Ján Tomko jtomko at redhat.com
Thu Apr 19 08:11:17 UTC 2018


On Wed, Apr 18, 2018 at 05:33:36PM +0200, Peter Krempa wrote:
>Prepare the tests for adding the new parameter. The parameter was
>introduced in qemu-2.7.0, so add a forked version of the test case to
>see that it is formatted properly.
>
>This test is also an example how the new testing macros should be used.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> .../disk-drive-write-cache.x86_64-2.6.0.args       | 43 +++++++++++++++++++++
> .../disk-drive-write-cache.x86_64-2.7.0.args       | 43 +++++++++++++++++++++
> .../disk-drive-write-cache.x86_64-latest.args      | 45 ++++++++++++++++++++++
> tests/qemuxml2argvdata/disk-drive-write-cache.xml  | 45 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c                           |  3 ++
> 5 files changed, 179 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.x86_64-2.6.0.args
> create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.x86_64-2.7.0.args
> create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180419/b6302ba5/attachment-0001.sig>


More information about the libvir-list mailing list