[libvirt] [PATCH v2 05/11] conf: Add flag to regenerate genid for virDomainDefCopy

[Peter Krempa]

On Mon, Apr 23, 2018 at 19:59:59 -0400, John Ferlan wrote:
> Add the VIR_DOMAIN_DEF_COPY_NEWGENID to indicate that the generated
> domain definition should adjust the genid value before returning the
> @def to the caller.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/conf/domain_conf.c | 12 ++++++++++++
>  src/conf/domain_conf.h |  5 +++++
>  src/qemu/qemu_driver.c |  3 ++-
>  src/test/test_driver.c |  3 ++-
>  4 files changed, 21 insertions(+), 2 deletions(-)

IMO all this code should not be necessary. Code paths which knowingly
need to change the GENID should do so explicitly rather than pulling the
logic here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180424/7d521dc1/attachment-0001.sig>