[libvirt] [PATCH libvirt v2 3/9] remote: Add the information which program has to be used to daemonClientEventCallback

Marc Hartmayer mhartmay at linux.vnet.ibm.com
Thu Apr 26 16:12:11 UTC 2018


On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan <jferlan at redhat.com> wrote:
> On 04/12/2018 08:40 AM, Marc Hartmayer wrote:
>> As a result, you can later determine at the callback which program has
>
> s/at/during
> s/has to be/was
>
>> to be used. This makes it easier to refactor the code in the future
>> and is less prone to error.
>>
>> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
>> ---
>>  src/remote/remote_daemon_dispatch.c | 108 ++++++++++++++++++++----------------
>>  1 file changed, 59 insertions(+), 49 deletions(-)
>>
>
> The $SUBJ is a bit long...
>
> How about just:
>
> remote: Save reference to program in daemonClientEventCallback

Yep, that’s better.

>
>
>
> Reviewed-by: John Ferlan <jferlan at redhat.com>

Thanks.

>
> John
>
--
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





More information about the libvir-list mailing list