[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [jenkins-ci PATCH 5/8] guests: Drop install_config from inventory



On Wed, 2018-08-01 at 14:46 +0200, Erik Skultety wrote:
> On Thu, Jul 19, 2018 at 06:32:05PM +0200, Andrea Bolognani wrote:
> >              # preseed files must use a well-known name to be picked up by
> >              # d-i; for kickstart files, we can use whatever name we please
> >              # but we need to point anaconda in the right direction through
> >              # a kernel argument
> > -            extra_arg = "console=ttyS0 ks=file:/{}".format(
> > -                facts["install_config"],
> > -            )
> > +            extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
> 
> Pre-existing, but ks= should be replaced by inst.ks, as using the inst. prefix
> is the current preferred way of passing installer-specific options, the legacy
> syntax is still accepted, however, this may be a subject to future changes -
> the inst. prefix is supported since fedora 17 and RHEL/CentOS 7 and since we
> dropped CentOS 6 from the supported distros, we don't need to keep the legacy
> option :).

Today I learned! :)

We can definitely switch to the non-legacy version, and I suspect
that if we spent some time on it we might be able to modernize the
kickstart file itself a bit as well...

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]