[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 27/32] util: perf: use VIR_AUTOFREE instead of VIR_FREE for scalar types



On Sat, Jul 28, 2018 at 11:31:42PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr gmail com>
> ---
>  src/util/virperf.c | 17 +++++------------
>  1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/src/util/virperf.c b/src/util/virperf.c
> index 4537cd0..1203a6e 100644
> --- a/src/util/virperf.c
> +++ b/src/util/virperf.c
> @@ -175,12 +175,12 @@ typedef struct virPerfEventAttr *virPerfEventAttrPtr;
>  static int
>  virPerfRdtAttrInit(void)
>  {
> -    char *buf = NULL;
> +    VIR_AUTOFREE(char *) buf = NULL;

I'll move this at the end of the declaration block.

Reviewed-by: Erik Skultety <eskultet redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]