[libvirt] [PATCH 2/9] conf: properly translate iscsi-direct storage pool

Ján Tomko jtomko at redhat.com
Tue Aug 7 14:27:21 UTC 2018


On Tue, Aug 07, 2018 at 03:55:21PM +0200, Pavel Hrdina wrote:
>We cannot simply used the same code as for iscsi storage pool because
>the default mode is 'host' which is not possible with iscsi-direct.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/conf/domain_conf.c | 61 +++++++++++++++++++++++++++++-------------
> 1 file changed, 43 insertions(+), 18 deletions(-)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 7dcbe8a20b..d1504610a1 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -30143,6 +30143,34 @@ virDomainDiskTranslateSourcePoolAuth(virDomainDiskDefPtr def,
> }
>
>
>+static int
>+virDomainDiskTranslateISCSIDircect(virDomainDiskDefPtr def,

s/Dircect/Direct/

>+                                   virStoragePoolDefPtr pooldef)
>+{
>+    def->src->srcpool->actualtype = VIR_STORAGE_TYPE_NETWORK;
>+    def->src->protocol = VIR_STORAGE_NET_PROTOCOL_ISCSI;
>+

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180807/45d9a49a/attachment-0001.sig>


More information about the libvir-list mailing list