[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] util: virnetdevopenvswitch: Drop an unused variable @ovs_timeout



On Wed, Aug 08, 2018 at 08:23:41AM +0200, Erik Skultety wrote:
Technically, it was never used ever since commit @f4d06ca8fd9 introduced
it, but the fact that we called VIR_FREE on it was enough for Clang to
never complain about it.

Signed-off-by: Erik Skultety <eskultet redhat com>
---

CC'ing Boris, as he allowed specifying timeouts for openvswitch calls, however,
this particular one hasn't been in use ever.


Looks like an oversight by Michal when he made adjustments before
pushing the series:
https://www.redhat.com/archives/libvir-list/2017-February/msg00407.html

The timeout addition is handled by virNetDevOpenvswitchAddTimeout,
this is harmless.

src/util/virnetdevopenvswitch.c | 1 -
1 file changed, 1 deletion(-)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]