[libvirt] [PATCH] spec: Use %make_install

Martin Kletzander mkletzan at redhat.com
Wed Aug 8 12:09:34 UTC 2018


On Tue, Jul 31, 2018 at 11:42:40AM -0400, Cole Robinson wrote:
>It's on RHEL7, saves a bit of typing, and lets us drop the comment
>

I tried it looks like it works.

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>Signed-off-by: Cole Robinson <crobinso at redhat.com>
>---
>There's also a %make_build macro which handles smp_mflags, but it uses
>make -O which makes build output noisier at least
>
> libvirt.spec.in | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/libvirt.spec.in b/libvirt.spec.in
>index 4113579e47..01f4e07b1c 100644
>--- a/libvirt.spec.in
>+++ b/libvirt.spec.in
>@@ -1255,10 +1255,7 @@ rm -fr %{buildroot}
>
> export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec)
>
>-# Avoid using makeinstall macro as it changes prefixes rather than setting
>-# DESTDIR. Newer make_install macro would be better but it's not available
>-# on RHEL 5, thus we need to expand it here.
>-make %{?_smp_mflags} install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} V=1
>+%make_install %{?_smp_mflags} SYSTEMD_UNIT_DIR=%{_unitdir} V=1
>
> make %{?_smp_mflags} -C examples distclean V=1
>
>-- 
>2.17.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180808/6c611239/attachment-0001.sig>


More information about the libvir-list mailing list