[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/9] conf: properly translate iscsi-direct storage pool



On Tue, Aug 07, 2018 at 04:27:21PM +0200, Ján Tomko wrote:
> On Tue, Aug 07, 2018 at 03:55:21PM +0200, Pavel Hrdina wrote:
> > We cannot simply used the same code as for iscsi storage pool because
> > the default mode is 'host' which is not possible with iscsi-direct.
> > 
> > Signed-off-by: Pavel Hrdina <phrdina redhat com>
> > ---
> > src/conf/domain_conf.c | 61 +++++++++++++++++++++++++++++-------------
> > 1 file changed, 43 insertions(+), 18 deletions(-)
> > 
> > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> > index 7dcbe8a20b..d1504610a1 100644
> > --- a/src/conf/domain_conf.c
> > +++ b/src/conf/domain_conf.c
> > @@ -30143,6 +30143,34 @@ virDomainDiskTranslateSourcePoolAuth(virDomainDiskDefPtr def,
> > }
> > 
> > 
> > +static int
> > +virDomainDiskTranslateISCSIDircect(virDomainDiskDefPtr def,
> 
> s/Dircect/Direct/

Nice catch, I'll fix it before pushing, thanks.

Pavel

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]