[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [jenkins-ci PATCH 11/12] lcitool: Support building arbitrary branches



On Wed, 2018-08-08 at 15:45 +0200, Andrea Bolognani wrote:
[...]
> -    def _action_update(self, hosts, projects):
> -        self._execute_playbook("update", hosts, projects)
> +    def _action_update(self, hosts, projects, _branch):
> +        self._execute_playbook("update", hosts, project, None)

Oops, made a mistake there... Consider the following squashed in:

diff --git a/guests/lcitool b/guests/lcitool
index 9d4b628..ec81448 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -482,7 +482,7 @@ class Application:
                 raise Error("Failed to install '{}'".format(host))

     def _action_update(self, hosts, projects, _branch):
-        self._execute_playbook("update", hosts, project, None)
+        self._execute_playbook("update", hosts, projects, None)

     def _action_build(self, hosts, projects, branch):
         if branch is None:
-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]