[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemuxml2xmloutdata: Use more symlinks



On Thu, Aug 09, 2018 at 04:50:58PM +0200, Michal Privoznik wrote:
There are couple of files that are the same in both
qemuxml2argvdata and qemuxml2xmloutdata directories. Link them
instead of having full copy.

Signed-off-by: Michal Privoznik <mprivozn redhat com>
---
tests/qemuxml2xmloutdata/boot-floppy-q35.xml       | 33 +---------------
tests/qemuxml2xmloutdata/bootindex-floppy-q35.xml  | 33 +---------------

These two are a) identical to each other b) one of them will be made
redundant after Peter pushes the BOOTINDEX capability changes.
If you wait until he pushes it, there might be one less change needed in
this commit.

tests/qemuxml2xmloutdata/disk-virtio-queues.xml    | 35 +---------------
tests/qemuxml2xmloutdata/intel-iommu-machine.xml   | 27 +------------
tests/qemuxml2xmloutdata/intel-iommu.xml           | 27 +------------

These are also identical. It makes sense for them to point to their
respective source counterparts. But the followup question is, whether we
want to make the source files point to each other.

tests/qemuxml2xmloutdata/luks-disks.xml            | 46 +---------------------
tests/qemuxml2xmloutdata/vcpu-placement-static.xml | 34 +---------------
7 files changed, 7 insertions(+), 228 deletions(-)
mode change 100644 => 120000 tests/qemuxml2xmloutdata/boot-floppy-q35.xml
mode change 100644 => 120000 tests/qemuxml2xmloutdata/bootindex-floppy-q35.xml
mode change 100644 => 120000 tests/qemuxml2xmloutdata/disk-virtio-queues.xml
mode change 100644 => 120000 tests/qemuxml2xmloutdata/intel-iommu-machine.xml
mode change 100644 => 120000 tests/qemuxml2xmloutdata/intel-iommu.xml
mode change 100644 => 120000 tests/qemuxml2xmloutdata/luks-disks.xml
mode change 100644 => 120000 tests/qemuxml2xmloutdata/vcpu-placement-static.xml


One way or another:
Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]