[libvirt] [RFC 0/2] util: introduce timeout mode in virCommandRun/Async and virKModLoad

Daniel P. Berrangé berrange at redhat.com
Mon Aug 13 08:02:02 UTC 2018


On Mon, Aug 13, 2018 at 02:32:17PM +0800, Shi Lei wrote:
> Hi, everyone!
> It's possible that the running-time of a command is long than its caller
> expected. Perhaps, it's useful to provide timeout mode for virCommandRun or
> virCommandRunAsync + virCommandWait. And The caller can restrict the
> running time of the command if necessary. I introduce a new function
> virCommandSetTimeout for that.
> 
> And then, virKModLoad will get a default timeout of 3 seconds. I hope it
> could solve the problem of "strange delay" as John mentioned.

I'm not really see what this is hoping to solve. If something in libvirt
is running virKModLoad, I cannot see how it will work better by not waiting
for it to complete.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list