[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Require libiscsi-devel instead of libiscsi



On Tue, Aug 14, 2018 at 01:44:40PM +0200, Andrea Bolognani wrote:
> Commit 34a6962c41b4 added a BuildRequires for the
> iscsi-direct backend, but we need the headers rather
> than the runtime package to be available in order to
> link against the library.
> 
> Signed-off-by: Andrea Bolognani <abologna redhat com>
> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 788483cdd4..63834767dd 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -320,7 +320,7 @@ BuildRequires: lvm2
>  # For pool type=iscsi
>  BuildRequires: iscsi-initiator-utils
>  # For pool type=iscsi-direct
> -BuildRequires: libiscsi
> +BuildRequires: libiscsi-devel
>  # For disk driver
>  BuildRequires: parted-devel
>  # For Multipath support

This change is correct but it's not good enough to fix all the issues in
specfile related to iscsi-direct, I'll post a patch in a minute that
fixes remaining issues including this one.

Pavel

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]