[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 00/11] More virAuthGet* cleanups



In a case of review collision, Michal pushed Marcos Paulo de Souza's
series after I had reviewed, but before seeing my review (oh well):

https://www.redhat.com/archives/libvir-list/2018-August/msg00874.html

Rather than worry about it, here's a series of changes that I
described in my review:

https://www.redhat.com/archives/libvir-list/2018-August/msg00860.html

based on top of Marcos' now pushed weries.

The only thing I didn't cover in this was my comment regarding
xenapiUtil_RequestPassword - I just left it as is.

John Ferlan (11):
  util: Alter virAuthGet*Path API to check valid parameters
  util: Alter virAuthGet*Path API to check valid callback
  util: Remove invalid parameter checks from
    virAuthGet{Username|Password}
  util: Alter virAuthGet*Path API return processing
  util: Alter virAuthGet*Path API to generate auth->cb error
  esx: Don't overwrite virAuthGet{Username|Password} errors
  hyperv: Don't overwrite virAuthGet{Username|Password} errors
  phyp: Don't overwrite virAuthGet{Username|Password} errors
  xenapi: Don't overwrite virAuthGet{Username|Password} errors
  test: Don't overwrite virAuthGet{Username|Password} errors
  rpc: Don't overwrite virAuthGet{Username|Password}Path errors

 src/esx/esx_driver.c          | 27 ++++------------
 src/hyperv/hyperv_driver.c    | 16 +++------
 src/phyp/phyp_driver.c        | 16 +++------
 src/rpc/virnetlibsshsession.c |  2 --
 src/rpc/virnetsshsession.c    |  5 +--
 src/test/test_driver.c        | 15 +++------
 src/util/virauth.c            | 61 ++++++++++++++++++++++++-----------
 src/xenapi/xenapi_driver.c    | 16 +++------
 8 files changed, 67 insertions(+), 91 deletions(-)

-- 
2.17.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]