[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rpc: Initialize a worker pool for max_workers=0 as well



On Tue, Aug 14, 2018 at 06:19 PM +0200, John Ferlan <jferlan redhat com> wrote:
> On 08/07/2018 07:38 AM, Marc Hartmayer wrote:
>> Semantically, there is no difference between an uninitialized worker
>> pool and an initialized worker pool with zero workers. Let's allow the
>> worker pool to be initialized for max_workers=0 as well then which
>> makes the API more symmetric and simplifies code. Validity of the
>> worker pool is delegated to virThreadPoolGetMaxWorkers instead.
>> 
>> This patch fixes segmentation faults in
>> virNetServerGetThreadPoolParameters and
>> virNetServerSetThreadPoolParameters for the case when no worker pool
>> is actually initialized (max_workers=0).
>> 
>> Signed-off-by: Marc Hartmayer <mhartmay linux ibm com>
>> ---
>>  src/rpc/virnetserver.c | 8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>> 
>
> Had to go refresh my memory on the previous series ;-)...
>
> Reviewed-by: John Ferlan <jferlan redhat com>
>
> John
>
> (and pushed)
>

Thanks :)

-- 
Beste Grüße / Kind regards
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]