[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 13/62] qemu: monitor: Add 'nodename' argument for 'block_resize'



On Wed, Aug 15, 2018 at 10:43:23 +0200, Ján Tomko wrote:
> On Mon, Aug 13, 2018 at 05:59:47PM +0200, Peter Krempa wrote:
> > Allow referring to individual node name to rezise.
> 
> s/rezise/resize/
> 
> > 
> > Signed-off-by: Peter Krempa <pkrempa redhat com>
> > ---
> > src/qemu/qemu_driver.c       |  2 +-
> > src/qemu/qemu_monitor.c      | 12 ++++++++++--
> > src/qemu/qemu_monitor.h      |  3 ++-
> > src/qemu/qemu_monitor_json.c |  4 +++-
> > src/qemu/qemu_monitor_json.h |  3 ++-
> > tests/qemumonitorjsontest.c  |  2 +-
> > 6 files changed, 19 insertions(+), 7 deletions(-)
> > 
> > diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
> > index 35d24cfb22..3da4d3076a 100644
> > --- a/tests/qemumonitorjsontest.c
> > +++ b/tests/qemumonitorjsontest.c
> > @@ -1320,7 +1320,7 @@ cleanup: \
> > }
> > 
> > GEN_TEST_FUNC(qemuMonitorJSONSetLink, "vnet0", VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN)
> > -GEN_TEST_FUNC(qemuMonitorJSONBlockResize, "vda", 123456)
> > +GEN_TEST_FUNC(qemuMonitorJSONBlockResize, "vda", "asdf", 123456)
> 
> Good to see you lead by example and only specified one of the two.

Well, the purpose here is to force schema detection to validate that the
given argument is present in the QAPI schema in a very simple way.

The schema can't express exclusivity of those two so we are okay at this
point and we can be certain that the field names are correct.

Unfortunately the GEN_TEST_FUNC macro is not flexible enough to allow
multiple invocations.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]