[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Add firmware/nvram paths for edk2 arm and ia32



On 08/15/2018 07:17 AM, Andrea Bolognani wrote:
On Wed, 2018-08-08 at 19:45 -0400, Cole Robinson wrote:
And clarify the comments to instead mention the package names
that provide these files

Please split this into two patches - one that tweaks the
existing comments and one that adds new entries.

[...]
-    # Nightly firmware repo x86/OVMF
+    # Nightly edk2.git-ovmf-x64
      LOADERS="/usr/share/edk2.git/ovmf-x64/OVMF_CODE-pure-efi.fd:/usr/share/edk2.git/ovmf-x64/OVMF_VARS-pure-efi.fd"
-    # Nightly firmware repo aarch64/AAVMF
+    # Nightly edk2.git-ovmf-ia32
+    LOADERS="/usr/share/edk2.git/ovmf-ia32/OVMF_CODE-pure-efi.fd:/usr/share/edk2.git/ovmf-ia32/OVMF_VARS-pure-efi.fd"

I'm pretty sure this won't work ;)


Argh, sorry, nice catch though. I'll fix and split it like you suggest

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]