[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/5] qemu: capabilities: Always assume QEMU_CAPS_ADD_FD



On 08/14/2018 03:21 PM, Peter Krempa wrote:
> The capability was usable since qemu 1.3 so we can remove all the
> detection code.
> 
> Signed-off-by: Peter Krempa <pkrempa redhat com>
> ---
> 
> Note that the *replies files need to be renumbered. I've split that to a
> separate patch for ease of review. Notably because it was done
> automatically by tests/qemucapsfixreplies.
> 
>  src/qemu/qemu_capabilities.c                       | 17 ------------
>  src/qemu/qemu_capabilities.h                       |  2 +-
>  src/qemu/qemu_command.c                            | 32 ++++++++++------------
>  .../qemucapabilitiesdata/caps_1.5.3.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_1.6.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_1.7.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml   |  3 +-
>  .../caps_2.10.0.aarch64.replies                    | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml |  3 +-
>  .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   |  3 +-
>  .../caps_2.10.0.x86_64.replies                     | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  |  3 +-
>  .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   |  3 +-
>  .../caps_2.11.0.x86_64.replies                     | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml  |  3 +-
>  .../caps_2.12.0.aarch64.replies                    | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml |  3 +-
>  .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   |  3 +-
>  .../caps_2.12.0.x86_64.replies                     | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  |  3 +-
>  .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  3 +-
>  .../caps_2.6.0.aarch64.replies                     | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml  |  3 +-
>  .../qemucapabilitiesdata/caps_2.6.0.ppc64.replies  | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml    |  3 +-
>  .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.7.0.s390x.replies  | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml    |  3 +-
>  .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.8.0.s390x.replies  | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |  3 +-
>  .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.9.0.ppc64.replies  | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml    |  3 +-
>  .../qemucapabilitiesdata/caps_2.9.0.s390x.replies  | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml    |  3 +-
>  .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_3.0.0.ppc64.replies  | 17 ------------
>  tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml    |  3 +-
>  .../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 17 ------------
>  tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   |  3 +-
>  tests/qemuxml2argvtest.c                           |  2 --
>  60 files changed, 43 insertions(+), 570 deletions(-)

ACK if you squash 5/5 into this one.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]