[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/7] lock_driver.h: Introduce metadata flag




On 08/14/2018 07:19 AM, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/locking/lock_driver.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/locking/lock_driver.h b/src/locking/lock_driver.h
> index 8b7cccc521..7c8f79520a 100644
> --- a/src/locking/lock_driver.h
> +++ b/src/locking/lock_driver.h
> @@ -56,6 +56,8 @@ typedef enum {
>      VIR_LOCK_MANAGER_RESOURCE_READONLY = (1 << 0),
>      /* The resource is assigned in shared, writable mode */
>      VIR_LOCK_MANAGER_RESOURCE_SHARED   = (1 << 1),
> +    /* The resource is locked for metadata change */
> +    VIR_LOCK_MANAGER_RESOURCE_METADATA = (1 << 2),

Does this work or make sense for lease type?

Of course this adds something that would "conceivably" be available such
that we may want to document it on
https://libvirt.org/internals/locking.html, but then again that's so
sparse it would take a bit of spelunking in the code to figure it out.

Anyway, since the name itself seems reasonable to me,

Reviewed-by: John Ferlan <jferlan redhat com>

if you add a few more details around it related to disk vs. lease that'd
be nice. If you update the docs eventually with all that you've learned,
then that'd be great too!

John


>  } virLockManagerResourceFlags;
>  
>  typedef enum {
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]