[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 00/12] PCI passthrough support on s390



On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote:
> Abstract
> ========
> The PCI representation in QEMU has recently been extended for S390
> allowing configuration of zPCI attributes like uid (user-defined
> identifier) and fid (PCI function identifier).
> The details can be found here:
> https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07262.html
> 
> To support the new zPCI feature of the S390 platform, two new XML
> attributes, @uid and @fid, are introduced for device addresses of type
> 'pci', i.e.:
>   <hostdev mode='subsystem' type='pci'>
>     <driver name='vfio'/>
>     <source>
>       <address domain='0x0001' bus='0x00' slot='0x00' function='0x0'/>
>     </source>
>     <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'
>       uid='0x0003' fid='0x00000027'/>
>   </hostdev>

Overall thoughts on the series: the direction is good and the
design looks solid, but there are still a few questions regarding
the implementation that we'll need to figure out.

We also need someone experienced in the area to look over the
hotplug part, and I would feel way more comfortable merging this
if Laine could go over the changes too... Hopefully he'll find
time to do that when v3 rolls around :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]