[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [jenkins-ci PATCH v2 2/2] projects: Document rationale for skipping jobs



On Tue, Aug 21, 2018 at 12:38:06PM +0200, Andrea Bolognani wrote:
> In general, we strive for full coverage and build all
> projects on all targets; however, in some cases that's
> simply not feasible and we have to skip the corresponding
> job. Document the rationale for each such case.
>
> Signed-off-by: Andrea Bolognani <abologna redhat com>
> ---
>  projects/libvirt-dbus.yaml    | 3 +++
>  projects/libvirt-sandbox.yaml | 3 +++
>  projects/libvirt-tck.yaml     | 2 ++
>  projects/libvirt.yaml         | 2 ++
>  projects/virt-manager.yaml    | 1 +
>  projects/virt-viewer.yaml     | 2 ++
>  6 files changed, 13 insertions(+)
>
> diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml
> index fdfb615..459bd96 100644
> --- a/projects/libvirt-dbus.yaml
> +++ b/projects/libvirt-dbus.yaml
> @@ -2,6 +2,7 @@
>  - project:
>      name: libvirt-dbus
>      machines:

I'd appreciate an empty line above the comments, it's adds to the readability.

> +      # Debian 8 doesn't have a recent enough GLib
>        - libvirt-centos-7
>        - libvirt-debian-9
>        - libvirt-fedora-27
> @@ -17,6 +18,7 @@
>            parent_jobs: 'libvirt-glib-master-build'
>        - autotools-syntax-check-job:
>            parent_jobs: 'libvirt-dbus-master-build'
> +          # The test suite uses Python 3, which CentOS 7 doesn't include
>            machines:
>              - libvirt-debian-9
>              - libvirt-fedora-27
> @@ -26,6 +28,7 @@
>              - libvirt-freebsd-11
>        - autotools-check-job:
>            parent_jobs: 'libvirt-dbus-master-syntax-check'
> +          # syntax-check uses Python 3, which CentOS 7 doesn't include
>            machines:
>              - libvirt-debian-9
>              - libvirt-fedora-27
> diff --git a/projects/libvirt-sandbox.yaml b/projects/libvirt-sandbox.yaml
> index da9bf77..6a474c8 100644
> --- a/projects/libvirt-sandbox.yaml
> +++ b/projects/libvirt-sandbox.yaml
> @@ -1,6 +1,9 @@
>
>  - project:
>      name: libvirt-sandbox
> +    # libvirt-sandbox is Linux only; among Linux platforms, CentOS 7 has
> +    # to be excluded because it doesn't ship a version of xz suitable for
> +    # statically linking against

Hmm, for some reason this doesn't sound "English" to me, how about:

s/statically linking against/linking statically/

Reviewed-by: Erik Skultety <eskultet redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]