[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] doc: better explanation for virStoragePoolSetAutostart



On Wed, Aug 22, 2018 at 08:43:32AM +0300, Dan Kenigsberg wrote:
> The former documentation was an unhelpful tautology. The suggested doc
> mimicks^Wcopies the one of virDomainSetAutostart.
>
> Signed-off-by: Dan Kenigsberg <danken redhat com>
> ---
>  src/libvirt-storage.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c
> index 1879c6bd60..ed305b9b5e 100644
> --- a/src/libvirt-storage.c
> +++ b/src/libvirt-storage.c
> @@ -1127,7 +1127,8 @@ virStoragePoolGetAutostart(virStoragePoolPtr pool,
>   * @pool: pointer to storage pool
>   * @autostart: new flag setting
>   *
> - * Sets the autostart flag
> + * Configure the storage pool to be automatically started
> + * when the host machine boots.

I rewrote the commit message a tiny bit and also changed the description of
@autostart argument to be consistent with the other uses too.

Reviewed-by: Erik Skultety <eskultet redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]