[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()



On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:

A short not explaining why you need to do this, along the lines of

  We're going to need to assign virtio-mmio addresses to non-ARM
  guests soon, so let's create a generic wrapper that calls to
  the architecture-specific implementation.

sure would be nice... Are you okay with me adding it to the commit
message before pushing?

Either way the code is fine, so

  Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]