[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 3/9] util: add RISC-V architectures



On Thu, 2018-08-23 at 17:30 +0200, Andrea Bolognani wrote:
> On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:
> > +    VIR_ARCH_RISCV32,      /* RISC-V      64 LE http://en.wikipedia.org/wiki/RISC-V */
> 
> This should be                               32 LE ...
> 
> > +    VIR_ARCH_RISCV64,      /* RISC-V      32 BE http://en.wikipedia.org/wiki/RISC-V */
> 
> ... and this should be                       64 LE
> 
> according to the corresponding implementation.
> 
> I'll take care of it before pushing.

I also had to squash in the diff below, which is necessary for
the build to succeed after commit d1a6d73ddff2 (pushed minutes
ago, so your series couldn't possibly account for that :).

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 6a3914bde2..9fae713c63 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2298,15 +2298,18 @@ static const char *preferredMachines[] =
     "pseries", /* VIR_ARCH_PPC64LE */
     "bamboo", /* VIR_ARCH_PPCEMB */

+    "spike_v1.10", /* VIR_ARCH_RISCV32 */
+    "spike_v1.10", /* VIR_ARCH_RISCV64 */
     NULL, /* VIR_ARCH_S390 (no QEMU impl) */
     "s390-ccw-virtio", /* VIR_ARCH_S390X */
     "shix", /* VIR_ARCH_SH4 */
+
     "shix", /* VIR_ARCH_SH4EB */
     "SS-5", /* VIR_ARCH_SPARC */
-
     "sun4u", /* VIR_ARCH_SPARC64 */
     "puv3", /* VIR_ARCH_UNICORE32 */
     "pc", /* VIR_ARCH_X86_64 */
+
     "sim", /* VIR_ARCH_XTENSA */
     "sim", /* VIR_ARCH_XTENSAEB */
 };
-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]