[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 8/8] qemu: monitor: Separate probing for active block commit



On Thu, Aug 23, 2018 at 18:11:09 -0400, John Ferlan wrote:
> 
> 
> On 08/15/2018 07:52 AM, Peter Krempa wrote:
> > Extract the code used to probe for the functionality so that it does not
> > litter the code used for actual work.
> > 
> > Signed-off-by: Peter Krempa <pkrempa redhat com>
> > ---
> >  src/qemu/qemu_monitor.c      |  2 +-
> >  src/qemu/qemu_monitor_json.c | 58 ++++++++++++++++++++++++++------------------
> >  src/qemu/qemu_monitor_json.h |  3 +++
> >  3 files changed, 39 insertions(+), 24 deletions(-)
> > 
> 
> This one somehow feels related to the other series I reviewed where the
> *top was or wasn't present to determine whether capability was there,
> but I see that it'd still be useful - just the irony of it all.

Your feelings are spot on. I was doing this commit when I realized
that the detection is pointless at this point and cleaned it up right
away so that we don't have to carry it around forever.

The removal of the detection is orthogonal to this cleanup though and
since we can't delete the detection code completely at this point thus
the other patches were sent in a separate series.

> 
> Reviewed-by: John Ferlan <jferlan redhat com>
> 
> John
> 
> 
> > diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
> > index 9bc7aa9ed1..a60e78d967 100644
> > --- a/src/qemu/qemu_monitor.c
> > +++ b/src/qemu/qemu_monitor.c
> 
> NB: My gitk view shows a few lines above here the call to
> qemuMonitorJSONBlockCommit has a second row of args that are not aligned
> properly...  Trivialities.

That will be fixed later. I'm adding few new args for block-commit.

That was not published yet though.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]