[libvirt] [PATCH v2] process: Ignore nwfilter binding instantiation issues during reconnect
John Ferlan
jferlan at redhat.com
Fri Aug 24 13:05:06 UTC 2018
On 08/24/2018 09:04 AM, Daniel P. Berrangé wrote:
> On Fri, Aug 24, 2018 at 08:30:50AM -0400, John Ferlan wrote:
>> +static void
>> +qemuProcessFiltersInstantiate(virDomainDefPtr def)
>> {
>> size_t i;
>>
>> for (i = 0; i < def->nnets; i++) {
>> virDomainNetDefPtr net = def->nets[i];
>> if ((net->filter) && (net->ifname)) {
>> - if (virDomainConfNWFilterInstantiate(def->name, def->uuid, net, ignoreExists) < 0)
>> - return 1;
>> + if (virDomainConfNWFilterInstantiate(def->name, def->uuid, net) < 0) {
>> + VIR_INFO("filter '%s' instantiation for '%s' failed '%s'",
>> + net->filter, net->ifname, virGetLastErrorMessage());
>
> Won't this cause a log message on every single running guests on every
> libvirtd restart, since the normal scenario is that the filter binding
> exists ?
>
Yes, that was explained under the ---
John
More information about the libvir-list
mailing list