[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 7/8] cpu: split x86 map data into separate files



On Thu, Aug 16, 2018 at 13:10:30 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange redhat com>
> ---
...
> diff --git a/src/cpu_map/x86_qemu64.xml b/src/cpu_map/x86_qemu64.xml
> new file mode 100644
> index 0000000000..ed3b8d54e2
> --- /dev/null
> +++ b/src/cpu_map/x86_qemu64.xml
> @@ -0,0 +1,40 @@
> +<cpus>
> +  <model name='qemu64'>
> +    <!-- These are supported only by TCG.  KVM supports them only if the
> +         host does.  So we leave them out:
> +
> +<feature name='abm'/>
> +<feature name='lahf_lm'/>
> +<feature name='popcnt'/>
> +<feature name='sse4a'/>

I'd indent these features..

> +    -->
> +    <feature name='apic'/>
> +    <feature name='clflush'/>
...
> +    <feature name='pse36'/>
> +    <feature name='sep'/>
> +    <feature name='sse'/>
> +    <feature name='sse2'/>
> +    <feature name='svm'/>
> +    <feature name='syscall'/>
> +    <feature name='tsc'/>
> +  </model>
> +

Extra empty line.

> +</cpus>
> diff --git a/src/cpu_map/x86_vendors.xml b/src/cpu_map/x86_vendors.xml
> new file mode 100644
> index 0000000000..418712af21
> --- /dev/null
> +++ b/src/cpu_map/x86_vendors.xml
> @@ -0,0 +1,4 @@
> +<cpus>
> +  <vendor name='Intel' string='GenuineIntel'/>
> +  <vendor name='AMD' string='AuthenticAMD'/>
> +</cpus>

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]