[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Introduce state_lock_ timeout to qemu.conf



Thanks for your review, Michal.
I will send a v2 patch.

> On 08/27/2018 08:04 AM, Yi Wang wrote:
> > When doing some job holding state lock for a long time,
> > we may come across error:
> > "Timed out during operation: cannot acquire state change lock"
> > Well, sometimes it's not a problem and users wanner continue
> > to wait, and this patch allow users decide how long time they
> > can wait the state lock.
> >
> > Signed-off-by: Yi Wang <wang yi59 zte com cn>
> > Reviewed-by: Xi Xu <xu xi8 zte com cn>
> > ---
> >  src/qemu/libvirtd_qemu.aug         | 1 +
> >  src/qemu/qemu.conf                 | 6 ++++++
> >  src/qemu/qemu_conf.c               | 3 +++
> >  src/qemu/qemu_conf.h               | 2 ++
> >  src/qemu/qemu_domain.c             | 6 +++++-
> >  src/qemu/test_libvirtd_qemu.aug.in | 1 +
> >  6 files changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
> > index ddc4bbf..f7287ae 100644
> > --- a/src/qemu/libvirtd_qemu.aug
> > +++ b/src/qemu/libvirtd_qemu.aug
> > @@ -93,6 +93,7 @@ module Libvirtd_qemu =
> >                   | limits_entry "max_core"
> >                   | bool_entry "dump_guest_core"
> >                   | str_entry "stdio_handler"
> > +                 | int_entry "state_lock_timeout"
> >
> >     let device_entry = bool_entry "mac_filter"
> >                   | bool_entry "relaxed_acs_check"
> > diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
> > index cd57b3c..e88db3f 100644
> > --- a/src/qemu/qemu.conf
> > +++ b/src/qemu/qemu.conf
> > @@ -813,3 +813,9 @@
> >  #
> >  #swtpm_user = "tss"
> >  #swtpm_group = "tss"
> > +
> > +# Override the timeout (in seconds) for acquiring state lock.
> > +#
> > +# Default is 0
> > +#
> > +#state_lock_timeout = 60
>
> Firstly, the default value should be set for the variable. So if the
> default is really 0 (which it is not) then this line should read:


---
Best wishes
Yi Wang

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]