[libvirt] [PATCH v4] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion

[Ján Tomko]

On Mon, Aug 27, 2018 at 09:50:07AM +0200, Katerina Koukiou wrote:
>This patch ensures that changes in attributes of interfaces will emit
>errors accept if they are missing from the XML.

except

>Previously we were falsely reporting successful updates, because some
>changed attributes got overwritten before the validity checks.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1599513
>
>Signed-off-by: Katerina Koukiou <kkoukiou at redhat.com>
>---
>Changes from v3:
>
>Adjusted to Jano's comments in v3; type and address are now checked together.
>
> src/qemu/qemu_hotplug.c | 33 ++++++++++++++++++++++++---------
> 1 file changed, 24 insertions(+), 9 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180827/efa7dd5a/attachment-0001.sig>