[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4] qemu: qemuDomainChangeNet: validity checks should be done before XML autocompletion



On Mon, Aug 27, 2018 at 09:50:07AM +0200, Katerina Koukiou wrote:
This patch ensures that changes in attributes of interfaces will emit
errors accept if they are missing from the XML.

except

Previously we were falsely reporting successful updates, because some
changed attributes got overwritten before the validity checks.

https://bugzilla.redhat.com/show_bug.cgi?id=1599513

Signed-off-by: Katerina Koukiou <kkoukiou redhat com>
---
Changes from v3:

Adjusted to Jano's comments in v3; type and address are now checked together.

src/qemu/qemu_hotplug.c | 33 ++++++++++++++++++++++++---------
1 file changed, 24 insertions(+), 9 deletions(-)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]