[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/8] virstorageobj: Move virStoragePoolObjSourceFindDuplicate and friends up




On 08/20/2018 08:09 AM, Michal Privoznik wrote:
> This function is going to be made static in used in
> virStoragePoolObjAssignDef(). Therefore move it and all the
> static functions it calls a few lines up.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/conf/virstorageobj.c | 788 +++++++++++++++++++++++------------------------
>  1 file changed, 394 insertions(+), 394 deletions(-)
> 

Ugh, what a mess git diff makes... need some --patience on the diff

Still consider my patch 3 suggestion about combining this with patch
2... It then just becomes a "reorganize the code" type patch where all
the Add/Del, GetNum, GetName, and Export are lumped together.

Either way,

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]