[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Fix mention of disk pool default




On 08/29/2018 06:22 PM, Eric Blake wrote:
> The default disk storage pool type is 'dos', not 'msdos'.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
> 
> I ran into this doc bug when trying to figure out why a disk storage
> pool that I had copied from another machine wouldn't autostart; it
> turns out that the old disk used BIOS partitioning (dos), and the new
> one uses UEFI (gpt).
> 
> I wonder if it would be nicer if a disk pool without a default
> partition type supplied by the user could auto-detect the right
> format, rather than defaulting to dos, but that's a bigger question
> that I won't be tackling, and wouldn't have necessarily helped me
> (if the <target> element was already present when I copied the file).
> 
>  docs/storage.html.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Automatic probing of volumes is/was a security issue and removed during
v4.5.0 - the last vestiges were commit e1e8d0a9b with the qemu.conf
adjustment in commit c95f50cb.

In any case, with respect to the patch in particular...

"dos" is the expected <format type='%s'...> value; however, "msdos" is
the value used by "parted mklabel --script msdos" (see
virStorageBackendDiskBuildPool)

So that line in the storage page for the Disk pool description isn't
entirely wrong, but it is somewhat misleading. I would say it's more
that the pool format is dos which generates an on disk partition format
of msdos (or some sort of wordsmithing).

In any case, I'm OK with changing to just "dos", but I won't complain if
the partition format verbiage is added.

Reviewed-by: John Ferlan <jferlan redhat com>
SFF,

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]