[libvirt] [PATCH v2 2/2] nwfilter: Check for filter presence before open connect during teardown
Daniel P. Berrangé
berrange at redhat.com
Thu Aug 30 16:28:07 UTC 2018
On Thu, Aug 30, 2018 at 11:06:08AM -0400, John Ferlan wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1608275
>
> Instantiation of an nwfilter binding is only allowed when
> the net->filter is defined for the network; however, the
> teardown of the binding does not make this check. This
> leaves open the possibility that the teardown could be
> called during guest shutdown/teardown in session mode
> resulting in the following error being logged:
>
> error : nwfilterConnectOpen:383 : internal error: unexpected
> nwfilter URI path '/session', try nwfilter:///system
>
> So before going through the teardown processing, let's
> be sure the network had a filter and then attempt to
> get a connection. For session mode it's not even possible
> create an nwfilter binding.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/conf/domain_nwfilter.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list