[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 06/28] virLockManagerSanlockAddResource: Do not ignore unknown resource types




On 08/27/2018 04:08 AM, Michal Privoznik wrote:
> Currently, there are only two types of resource. So effectively
> this is a dead code. However, that assumption can change and we
> shouldn't just silently ignore the error.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/locking/lock_driver_sanlock.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

True and this then follows what lockd does in
virLockManagerLockDaemonAddResource

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]