[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 08/28] virLockManagerLockDaemonAddResource: Switch to cleanup label rather than error




On 08/27/2018 04:08 AM, Michal Privoznik wrote:
> This will help in future expansions of the code when it is be
> harder to track if @newName and/or @newLockspace were already
> allocated or not and thus whether it is safe to 'return' or we
> need to 'goto error'. By using the 'cleanup' label those two
> cases merge into a single one.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/locking/lock_driver_lockd.c | 44 ++++++++++++++++++++---------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]