[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/10] docs: don't refer to deprecated 'linux' ostype in example



On Thu, Aug 30, 2018 at 03:29:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 30, 2018 at 04:27:06PM +0200, Marek Marczykowski-Górecki wrote:
> > On Mon, Aug 27, 2018 at 03:23:16PM -0600, Jim Fehlig wrote:
> > > On 08/05/2018 03:48 PM, Marek Marczykowski-Górecki wrote:
> > > > Use preferred name: 'xen'.
> > > 
> > > I'd be fine with this change if the actual code used the preferred name too
> > > :-). E.g. config containing
> > > 
> > >   <type arch='x86_64' machine='xenpv'>xen</type>
> > > 
> > > will be shown as
> > > 
> > >   <type arch='x86_64' machine='xenpv'>linux</type>
> > > 
> > > after virsh define; virsh dumpxml. Also, virsh domxml-from-native will
> > > produce the linux variant.
> > 
> > I was thinking about this and decided to left it intact for backward
> > compatibility - so config from `virsh dumpxml` will work with very old
> > libvirt version. But if that would be acceptable, I'd very much like to
> > change that too. What are opinions about that?
> 
> We can't change what we are reporting in the XML here, no matter how
> stupid our original choice of terminology was.

Ok. What about other patches (not really depending on this one)?

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]