[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] lxc: check actual type of interface not config type



On Wed, Dec 05, 2018 at 09:35:13PM -0500, Laine Stump wrote:
> virLXCControllerGetNICIndexes() was deciding whether or not to add the
> ifindex for an interface's ifname to the list of ifindexes sent to
> CreateMachineWithNetwork based on the interface type stored in the
> config. This would be incorrect in the case of <interface
> type='network'> where the network was giving out macvlan interfaces
> tied to a physical device (i.e. when the actual interface type was
> "direct").
> 
> Instead of checking the setting of "net->type", we should be checking
> the setting of virDomainNetGetActualType(net).
> 
> I don't think this caused any actual misbehavior, it was just
> technically wrong.
> 
> Signed-off-by: Laine Stump <laine laine org>
> ---
>  src/lxc/lxc_controller.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]