[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] qemu: domain: gfx: Fix shadowing the ptr argument to graphics validation



On Tue, Dec 11, 2018 at 06:48:26PM -0500, John Ferlan wrote:
>
>
> On 12/7/18 9:47 AM, Erik Skultety wrote:
> > Since the code was never run, this stupid mistake could have only been
> > spotted by an accident.
> >
> > Signed-off-by: Erik Skultety <eskultet redhat com>
> > ---
> >  src/qemu/qemu_domain.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
>
> Gah - that wasn't obvious... and it's scary the compiler was silent.

Indeed it is. I'm just wondering when would I actually want to use this
legitimately since it's perfectly fine to assign into a "copy" pointer from
the standard's point of view.

Thanks,
Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]