[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote: Fix the build by explicitly casting the obj pointer for xdr_free



On Fri, Dec 14, 2018 at 10:11:55AM +0000, Daniel P. Berrangé wrote:
> On Fri, Dec 14, 2018 at 10:18:39AM +0100, Erik Skultety wrote:
> > For some reason, xdr_free uses char * instead of void * for its 2nd
> > argument which is passed to a custom free routine. Commit
> > dc54b3ec missed this detail which made the build fail on a number of
> > platforms. Fix it by explicitly casting the object pointer to char *
> > just like we do in other places throughout the code base.
>
> Which platforms did you see this on ?
>
> On Linux  libtirpc declares it correctly
>
>   extern void     xdr_free(xdrproc_t, void *);

Oh, then it's just the man-pages package on Fedora 29 which still reports the
wrong signature. Anyhow, CI reported the issue on Debian 8-9 and Centos7.

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]